bbovenzi commented on code in PR #30429:
URL: https://github.com/apache/airflow/pull/30429#discussion_r1197958901
##########
airflow/www/templates/airflow/dags.html:
##########
@@ -132,22 +132,38 @@ <h2>{{ page_title }}</h2>
<div id="main_content">
<div class="row dags-table-header">
<div class="col-sm-4 col-md-4 no-x-padding">
- <div class="form-group btn-group">
- <a
- href="{{ url_for('Airflow.index', status='all',
search=request.args.get('search', None), tags=request.args.getlist('tags',
None)) }}"
- class="btn {{ 'btn-primary' if status_filter == 'all' else
'btn-default' }}"
- title="Show active and paused DAGs">All <span class="badge">{{
"{:,}".format(status_count_all) }}</span></a>
- <a
- href="{{ url_for('Airflow.index', status='active',
search=request.args.get('search', None), tags=request.args.getlist('tags',
None)) }}"
- class="btn {{ 'btn-primary' if status_filter == 'active' else
'btn-default' }}"
- title="Show only active DAGs">Active <span class="badge">{{
"{:,}".format(status_count_active) }}</span></a>
- <a
- href="{{ url_for('Airflow.index', status='paused',
search=request.args.get('search', None), tags=request.args.getlist('tags',
None)) }}"
- class="btn {{ 'btn-primary' if status_filter == 'paused' else
'btn-default' }}"
- title="Show only paused DAGs">Paused <span class="badge">{{
"{:,}".format(status_count_paused) }}</span></a>
+ <div class="row">
+ <div class="col-sm-6 col-md-6">
+ <div class="form-group btn-group">
+ <a
+ href="{{ url_for('Airflow.index', status='all',
search=request.args.get('search', None), tags=request.args.getlist('tags',
None)) }}"
+ class="btn {{ 'btn-primary' if status_filter == 'all' else
'btn-default' }}"
+ title="Show active and paused DAGs">All <span class="badge">{{
"{:,}".format(status_count_all) }}</span></a>
+ <a
+ href="{{ url_for('Airflow.index', status='active',
search=request.args.get('search', None), tags=request.args.getlist('tags',
None)) }}"
+ class="btn {{ 'btn-primary' if status_filter == 'active' else
'btn-default' }}"
+ title="Show only active DAGs">Active <span class="badge">{{
"{:,}".format(status_count_active) }}</span></a>
+ <a
+ href="{{ url_for('Airflow.index', status='paused',
search=request.args.get('search', None), tags=request.args.getlist('tags',
None)) }}"
+ class="btn {{ 'btn-primary' if status_filter == 'paused' else
'btn-default' }}"
+ title="Show only paused DAGs">Paused <span class="badge">{{
"{:,}".format(status_count_paused) }}</span></a>
+ </div>
+ </div>
+ <div class="col-sm-3 col-md-3 text-center">
+ <div class="form-group btn-group">
+ <a
+ href="{{ url_for('Airflow.index', status='running',
search=request.args.get('search', None), tags=request.args.getlist('tags',
None)) }}"
+ class="btn {{ 'btn-primary' if status_filter == 'running' else
'btn-default' }}"
+ title="Show currently running DAG runs">Running <span
class="badge">{{ "{:,}".format(status_count_running) }}</span></a>
+ <a
+ href="{{ url_for('Airflow.index', status='failed',
search=request.args.get('search', None), tags=request.args.getlist('tags',
None)) }}"
+ class="btn {{ 'btn-primary' if status_filter == 'failed' else
'btn-default' }}"
+ title="Show DAGs with failed latest DAG run">Failed <span
class="badge">{{ "{:,}".format(status_count_failed) }}</span></a>
Review Comment:
The filter actually shows dags with any failed runs, not just the latest run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
