uranusjr commented on code in PR #31376:
URL: https://github.com/apache/airflow/pull/31376#discussion_r1198536284
##########
airflow/models/connection.py:
##########
@@ -186,16 +186,46 @@ def _normalize_conn_type(conn_type):
conn_type = conn_type.replace("-", "_")
return conn_type
+ @staticmethod
+ def split_uri_to_parts(uri):
+ c = uri.count("://")
+ if c < 2:
+ return urlsplit(uri), False
+ idx = uri.rfind("://")
+ # replace :// with :__
+ uri_list = list(uri)
+ uri_list[idx : idx + 3] = ":__"
+ uri = "".join(uri_list)
+ uri = urlsplit(uri)
+ uri = [e for e in uri]
+ # replace back :__ with ://
+ uri[1] = uri[1].replace(":__", "://")
+ uri = SplitResult(uri[0], uri[1], uri[2], uri[3], uri[4])
Review Comment:
And why do you need to do that list comprehention in the first place?
SplitResult supports index access out of the box.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
