shahar1 commented on code in PR #31433:
URL: https://github.com/apache/airflow/pull/31433#discussion_r1199823751
##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -893,7 +893,10 @@ def generate_query(self) -> str:
query += self.selected_fields
else:
query += "*"
- query += f" from `{self.project_id}.{self.dataset_id}.{self.table_id}`
limit {self.max_results}"
+ query += (
+ f" from `{self.project_id + '.' if self.project_id else
''}{self.dataset_id}"
Review Comment:
Yes, it should be equivalent. Soon I'll change it, as well as its unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
