Hajbo opened a new pull request, #31455:
URL: https://github.com/apache/airflow/pull/31455

   This change re-enables search in notes for the DagRun and TaskInstance views 
(under the Browse dropdown menu). 
   
   Turns out *desc.value_attr* is the column name in the remote table. This 
means that this only worked if the attribute with the association proxy had the 
same name as the associated column, otherwise the wrong column name was used as 
the key (e.g. content instead of note). The only instance this caused an issue 
was for the notes, the names were matching in all other cases that are shown in 
the UI. 
   
   I took the liberty to fix the note search for the TaskInstance view as well, 
at the expense of disabling ordering by note. Unfortunately sorting by an 
association proxy isn't supported, and mixing it with the actual field 
reference (table_name.column_name format) didn't solve the issue either.
   
   
   closes: #30042 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to