hussein-awala commented on code in PR #31391:
URL: https://github.com/apache/airflow/pull/31391#discussion_r1200152117
##########
airflow/providers/google/cloud/operators/kubernetes_engine.py:
##########
@@ -433,15 +433,6 @@ def __init__(
)
is_delete_operator_pod = False
- if use_internal_ip is not None:
- warnings.warn(
- f"You have set parameter use_internal_ip in class
{self.__class__.__name__}. "
- "In current implementation of the operator the parameter is
not used and will "
- "be deleted in future.",
- AirflowProviderDeprecationWarning,
- stacklevel=2,
- )
Review Comment:
It was deprecated (technically removed with deprecation warning) in #29266.
It seems like they assumed that the new connection method can connect to any
cluster through the public IP, without considering that some users disable
access to their cluster from the public network, and that the current method
always returns the public IP, even when public access is disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
