potiuk commented on PR #31470: URL: https://github.com/apache/airflow/pull/31470#issuecomment-1558863386
Example flaky test: https://github.com/apache/airflow/actions/runs/5054738339/jobs/9070519469?pr=31469 ``` _____________________ test_trigger_logging_sensitive_info ______________________ session = <sqlalchemy.orm.session.Session object at 0x7f2cb04f6880> capsys = <_pytest.capture.CaptureFixture object at 0x7f2cf9c99ca0> def test_trigger_logging_sensitive_info(session, capsys): """ Checks that when a trigger fires, it doesn't log any sensitive information from arguments """ class SensitiveArgOperator(BaseOperator): def __init__(self, password, **kwargs): self.password = password super().__init__(**kwargs) # Use a trigger that will immediately succeed trigger = SuccessTrigger() op = SensitiveArgOperator(task_id="sensitive_arg_task", ***"some_password") create_trigger_in_db(session, trigger, operator=op) triggerer_job = Job() triggerer_job_runner = TriggererJobRunner(triggerer_job) triggerer_job_runner.load_triggers() # Now, start TriggerRunner up (and set it as a daemon thread during tests) triggerer_job_runner.daemon = True triggerer_job_runner.trigger_runner.start() try: # Wait for up to 3 seconds for it to fire and appear in the event queue for _ in range(30): if triggerer_job_runner.trigger_runner.events: assert list(triggerer_job_runner.trigger_runner.events) == [(1, TriggerEvent(True))] break time.sleep(0.1) else: pytest.fail("TriggerRunner never sent the trigger event out") finally: # We always have to stop the runner triggerer_job_runner.trigger_runner.stop = True stdout = capsys.readouterr().out > assert "test_dag/test_run/sensitive_arg_task/-1/1 (ID 1) starting" in stdout E AssertionError: assert 'test_dag/test_run/sensitive_arg_task/-1/1 (ID 1) starting' in '[\x1b[34m2023-05-23T08:35:13.404+0000\x1b[0m] {\x1b[34mtriggerer_job_runner.py:\x1b[0m172} INFO\x1b[0m - Setting up T...g up logging queue listener with handlers [<RedirectStdHandler (NOTSET)>, <TriggererHandlerWrapper (NOTSET)>]\x1b[0m\n' tests/jobs/test_triggerer_job.py:147: AssertionError ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
