uranusjr commented on code in PR #31486:
URL: https://github.com/apache/airflow/pull/31486#discussion_r1205080336
##########
airflow/utils/db.py:
##########
@@ -1633,8 +1641,9 @@ def resetdb(session: Session = NEW_SESSION, skip_init:
bool = False):
connection = settings.engine.connect()
with create_global_lock(session=session, lock=DBLocks.MIGRATIONS):
- drop_airflow_models(connection)
- drop_airflow_moved_tables(session)
+ with connection.begin():
Review Comment:
Is this needed? The calls here are mostly DDL and I’m not sure a transaction
changes things much (and they weren’t wrapped in one previously).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
