hussein-awala commented on PR #30718: URL: https://github.com/apache/airflow/pull/30718#issuecomment-1562867691
The issue with these operators is that the default `is_delete_operator_pod` is not aligned with the KPO. Therefore, we need to handle this parameter individually for each subclass operator. Using `on_finish_action` as an argument for the super function won't work with the older version of the KPO. Additionally, providing `is_delete_operator_pod` will result in a deprecation warning being logged, even if the user provides `on_finish_action` for the GKE/EKS operator. IMO, the best solution is to check the KPO version until modifying the default value of `is_delete_operator_pod` for the GKE/EKS operator, which, btw, is already deprecated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
