pierrejeambrun commented on code in PR #31435:
URL: https://github.com/apache/airflow/pull/31435#discussion_r1206024833
##########
CONTRIBUTING.rst:
##########
@@ -1170,7 +1170,11 @@ To install yarn on macOS:
export PATH="$HOME/.yarn/bin:$PATH"
-4. Install third-party libraries defined in ``package.json`` by running the
+4. Install third-party libraries defined in ``package.json`` by running the
following command
Review Comment:
I don't think this should be the 4th step of `To install yarn on macOS:`,
this is not part of the yarn install process.
There is a section bellow to run the server in dev mode, maybe we could add
that as the first step before the `yarn run dev` ?
```
# Starts a web server that manages and updates your assets as you modify
them
# You'll need to run the webserver in debug mode too: ``airflow
webserver -d``
yarn run dev
```
edit: My bad, it was like this before and is part of a bigger section
[Installing yarn and its packages
manually](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#id55).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
