potiuk commented on PR #31576:
URL: https://github.com/apache/airflow/pull/31576#issuecomment-1565702149

   Ah. No. the explanation is simpler. You need to also update 
provider_info.schema.json  @eladkal and it unfortunately means that it cannot 
be implemented this way without breaking compatibility.
   
   The "notification" object type has been added here: 
https://github.com/apache/airflow/pull/29191 and relased in 2.6.0. The 
"provider_info" schema (unlike the provider.yaml" one ) is public-facing. 
Airflow expects the `provider_info" exposed by get_provider_info endpoint to 
conform to this schema. And it means that Airflow 2.6.* will not validate the 
provider_info properly.
   
   So this change will have to be done differently if we decide to do it. For 
example you could change the field from "notifications" to 
"airflow-notifications" and deprecate the "notifications" one. But it would be 
quite complex to implement. I am not sure if it is worth it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to