uranusjr commented on code in PR #29602:
URL: https://github.com/apache/airflow/pull/29602#discussion_r1208291601
##########
airflow/configuration.py:
##########
@@ -390,8 +390,14 @@ def _validate_max_tis_per_query(self) -> None:
"""
# TODO: this type of checking can be generalized like the deprecate
checking
- max_tis_per_query = self.getint("scheduler", "max_tis_per_query")
- parallelism = self.getint("core", "parallelism")
+ try:
+ max_tis_per_query = self.getint("scheduler", "max_tis_per_query")
+ parallelism = self.getint("core", "parallelism")
+ except AirflowConfigException:
+ # in case any of the above config not found, return directly
+ # this could happens in some unit tests
Review Comment:
But the implementation those tests cover does depend on the configuration.
If you do not want they to depend on it, your implementation to the config
needs to be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
