jens-scheffler-bosch opened a new pull request, #31583:
URL: https://github.com/apache/airflow/pull/31583

   closes: AIP-50 Project
   related: #31301
   
   This PR implements Part 2 of AIP-50 and once merged closes the AIP-50 
improvement.
   
   In this PR the behavior of the Trigger Button is changed to Option B as 
discussed in 
https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-50+Trigger+DAG+UI+Extension+with+Flexible+User+Form+Concept
 and voted in https://lists.apache.org/thread/4dkbwob1wyl3xjbqdsmbd1mvgzflzp1f
   
   Changes in this PR:
   * Trigger button will route to the Trigger UI form only if DAG has 
parameters, else it skips form display
   * Headline in trigger UI form adds a link back to DAG (I was strongly 
missing a way back :-D))
   * Route/endpoint of trigger UI was made consistent to other routes in DAG
   
   Note: This code touches also parts from PR #31301 - PR #31301 should be 
merged and this revised before merge
   
   How to test?
   * Start the Web UI and click on the "Trigger DAG" button in the DAG 
"example_params_ui_tutorial" - the form should be displayed. Trigger once to 
see that it still works
   * Start the Web UI and click on the "Trigger DAG" button in the DAG 
"dataset_consumes_1" - should start directly w/o displaying the form. A flash 
indicator should show that start was made.
   
   [ ] Merge PR #31301 before this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to