uranusjr commented on code in PR #31512:
URL: https://github.com/apache/airflow/pull/31512#discussion_r1209154013
##########
airflow/providers/apache/hdfs/hooks/webhdfs.py:
##########
@@ -153,3 +153,15 @@ def load_file(
hdfs_path=destination, local_path=source, overwrite=overwrite,
n_threads=parallelism, **kwargs
)
self.log.debug("Uploaded file %s to %s", source, destination)
+
+ def read_file(self, filename: str) -> bytes:
+ """Reads a file from HDFS
Review Comment:
```suggestion
"""Read a file from HDFS.
```
##########
airflow/providers/apache/hdfs/log/hdfs_task_handler.py:
##########
@@ -0,0 +1,136 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+import os
+import pathlib
+import shutil
+from urllib.parse import urlsplit
+
+from airflow.compat.functools import cached_property
+from airflow.configuration import conf
+from airflow.providers.apache.hdfs.hooks.webhdfs import WebHDFSHook
+from airflow.utils.log.file_task_handler import FileTaskHandler
+from airflow.utils.log.logging_mixin import LoggingMixin
+
+
+class HdfsTaskHandler(FileTaskHandler, LoggingMixin):
+ """HdfsTaskHandler is a python log handler that handles and reads
+ task instance logs. It extends airflow FileTaskHandler and
+ uploads to and reads from HDFS.
+ """
Review Comment:
```suggestion
"""Logging handler to upload and read from HDFS."""
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
