andriisoldatenko commented on a change in pull request #5665: [AIRFLOW-5048]
Improve display of Kubernetes resources
URL: https://github.com/apache/airflow/pull/5665#discussion_r307683466
##########
File path: airflow/kubernetes/pod.py
##########
@@ -37,6 +37,10 @@ def has_limits(self):
def has_requests(self):
return self.request_cpu is not None or self.request_memory is not None
+ def __str__(self):
+ return str({'request': {'memory': self.request_memory, 'cpu':
self.request_cpu},
Review comment:
`self.request_memory` can be None, may be check first?
same for `self.limit_memory`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
