ephraimbuddy commented on PR #31018: URL: https://github.com/apache/airflow/pull/31018#issuecomment-1567947772
> In general, there is a lot of duplicated code here. I think it is possible to refactor the existing code in `hooks/s3.py` to be able to work with both synchronous and asynchronous cases. I'm in the process of writing code to add deferrable mode to `S3KeySensor` as well as `S3KeysUnchangedSensor`, but I won't have a PR ready until about a week or so. Additionally, have you tested the system tests with the deferrable code? As far as I understand, if system tests are run with deferrable mode, `pytest` will exit once the operator raises a `TaskDeferred` exception, and there is no mechanism to resume test execution. The duplicated code can be a separate PR after this. @sunank200 can you run the system test with breeze. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
