[GitHub] [airflow] JoranDox commented on a diff in pull request #31421: Allow skipped task states task_instance_schema.py

Tue, 30 May 2023 07:39:21 -0700 


JoranDox commented on code in PR #31421:
URL: https://github.com/apache/airflow/pull/31421#discussion_r1210386706


##########
airflow/api_connexion/schemas/task_instance_schema.py:
##########
@@ -158,7 +158,9 @@ class SetTaskInstanceStateFormSchema(Schema):
     include_downstream = fields.Boolean(required=True)
     include_future = fields.Boolean(required=True)
     include_past = fields.Boolean(required=True)
-    new_state = TaskInstanceStateField(required=True, 
validate=validate.OneOf([State.SUCCESS, State.FAILED]))
+    new_state = TaskInstanceStateField(
+        required=True, validate=validate.OneOf([State.SUCCESS, State.FAILED, 
State.SKIPPED])

Review Comment:
   > Let’s change these to use TaskInstanceState instead (also the one below)
   
   Good point, I didn't dare but you're right, just did it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to