jedcunningham commented on code in PR #31467:
URL: https://github.com/apache/airflow/pull/31467#discussion_r1210980948
##########
airflow/www/templates/airflow/dags.html:
##########
@@ -215,13 +215,13 @@ <h2>{{ page_title }}</h2>
title="Status of all previous DAG runs.">info</span>
</th>
<th>Schedule</th>
- <th style="width:180px;">{{ sortable_column("Last Run",
"last_dagrun") }}
+ <th style="width:180px;">{{ sortable_column("Last Data Interval",
"last_dagrun") }}
Review Comment:
If we want to be pedantic here, isn't this the logical date?
##########
airflow/www/templates/airflow/dags.html:
##########
@@ -215,13 +215,13 @@ <h2>{{ page_title }}</h2>
title="Status of all previous DAG runs.">info</span>
</th>
<th>Schedule</th>
- <th style="width:180px;">{{ sortable_column("Last Run",
"last_dagrun") }}
+ <th style="width:180px;">{{ sortable_column("Last Data Interval",
"last_dagrun") }}
<span class="material-icons text-muted js-tooltip"
aria-hidden="true"
- title="Date/Time of the latest Dag Run.">info</span>
+ title="Starting Date/Time interval of the latest Dag
Run.">info</span>
Review Comment:
I find this confusing. I'd prefer we don't change the title (leave it "Last
Run") and change this to "Logical Date of the latest Dag Run.".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
