uranusjr commented on code in PR #31423:
URL: https://github.com/apache/airflow/pull/31423#discussion_r1212639459
##########
airflow/providers/amazon/aws/hooks/athena.py:
##########
@@ -153,7 +153,7 @@ def get_query_results(
) -> dict | None:
"""
Fetch submitted athena query results. returns none if query is in
intermediate state or
Review Comment:
```suggestion
Fetch submitted athena query results.
Returns none if query is in intermediate state or
```
##########
airflow/providers/amazon/aws/hooks/ecs.py:
##########
Review Comment:
Missed the periods in this file?
##########
airflow/providers/amazon/aws/hooks/athena.py:
##########
@@ -227,7 +227,7 @@ def poll_query_status(
) -> str | None:
"""
Poll the status of submitted athena query until query state reaches
final state.
Review Comment:
```suggestion
Poll the status of submitted athena query until query state reaches
final state.
```
##########
airflow/providers/amazon/aws/hooks/s3.py:
##########
@@ -207,8 +207,8 @@ def get_s3_bucket_key(
) -> tuple[str, str]:
"""
Get the S3 bucket name and key from either:
Review Comment:
```suggestion
Get the S3 bucket name and key.
From either:
```
##########
airflow/providers/amazon/aws/hooks/redshift_sql.py:
##########
@@ -147,7 +147,7 @@ def get_table_primary_key(self, table: str, schema: str |
None = "public") -> li
Helper method that returns the table primary key
:param table: Name of the target table
:param schema: Name of the target schema, public by default
- :return: Primary key columns list
+ :return: Primary key columns list.
Review Comment:
```suggestion
:return: Primary key columns list
```
##########
airflow/providers/amazon/aws/hooks/base_aws.py:
##########
@@ -584,7 +584,7 @@ def get_session(self, region_name: str | None = None,
deferrable: bool = False)
def _get_config(self, config: Config | None = None) -> Config:
"""
No AWS Operators use the config argument to this method.
Review Comment:
```suggestion
No AWS Operators use the config argument to this method.
```
##########
airflow/providers/amazon/aws/hooks/athena.py:
##########
@@ -188,7 +188,7 @@ def get_query_results_paginator(
"""
Fetch submitted athena query results. returns none if query is in
intermediate state or
Review Comment:
```suggestion
Fetch submitted athena query results.
Returns none if query is in intermediate state or
```
##########
airflow/providers/amazon/aws/hooks/redshift_sql.py:
##########
@@ -147,7 +147,7 @@ def get_table_primary_key(self, table: str, schema: str |
None = "public") -> li
Helper method that returns the table primary key
Review Comment:
```suggestion
Helper method that returns the table primary key.
```
##########
airflow/providers/amazon/aws/hooks/batch_client.py:
##########
@@ -231,7 +231,7 @@ def terminate_job(self, job_id: str, reason: str) -> dict:
def check_job_success(self, job_id: str) -> bool:
"""
Check the final status of the Batch job; return True if the job
Review Comment:
```suggestion
Check the final status of the Batch job.
Return True if the job
```
##########
airflow/providers/amazon/aws/hooks/s3.py:
##########
@@ -175,7 +175,7 @@ def parse_s3_url(s3url: str) -> tuple[str, str]:
"""
Parses the S3 Url into a bucket name and key.
Review Comment:
```suggestion
Parses the S3 Url into a bucket name and key.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
