vincbeck commented on code in PR #30463:
URL: https://github.com/apache/airflow/pull/30463#discussion_r1213207936
##########
airflow/providers/amazon/aws/operators/emr.py:
##########
@@ -901,36 +930,63 @@ def execute(self, context: Context) -> str | None:
raise AirflowException(f"Application Creation failed: {response}")
self.log.info("EMR serverless application created: %s", application_id)
-
- # This should be replaced with a boto waiter when available.
- waiter(
- get_state_callable=self.hook.conn.get_application,
- get_state_args={"applicationId": application_id},
- parse_response=["application", "state"],
- desired_state={"CREATED"},
- failure_states=EmrServerlessHook.APPLICATION_FAILURE_STATES,
- object_type="application",
- action="created",
- countdown=self.waiter_countdown,
- check_interval_seconds=self.waiter_check_interval_seconds,
- )
+ attempt = 0
+ waiter = self.hook.get_waiter("serverless_app_created")
+ while attempt < self.waiter_max_attempts:
Review Comment:
I see. I agree with you, we definitely need these logs and I am just sad
this is the only way to get these. Especially because it worsen the code. My
understanding is the waiter is pushing logs but at the DEBUG level right? Did
you try to increase the specific logger that is sending these logs? Then,
instead of pushing these logs to DEBUG level, it would do it, say, at INFO
level? See [here](https://github.com/boto/boto3/issues/521) more informations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
