pierrejeambrun commented on issue #31605:
URL: https://github.com/apache/airflow/issues/31605#issuecomment-1572890450

   `DAG` and `DagModel` are distinct entities with distinct attributes and 
purpose (even if some overlaps). Schemas suggest full inheritance for all 
attributes of `DAGModel` into `DAG` but it is not completely true, and some of 
them do not exist on a `DAG` instance. Therefore I think this is why they are 
missing from serialization on the `/details`.
   
   I think the idea was that a `SerializedDAG` has a lot more info than the 
DagModel (which just represents the DAG metadata), for instance children, 
task_group, tasks, UI colors, dag_dependencies to name a few and appeared as a 
natural base class for a ' detailed' dag view.
   
   I think schemas should be fixed to at least reflect what is actually 
returned by the API. (So the doc is not misleading anymore).
   
   Then if you need some additional information not yet available on the 
`/details` view, we can update it. (But that would mean adding attributes to 
the `SerializedDAG` class, which is not trivial and has some inplications on 
other components (scheduler, DagFileProcessor, serialization module etc...)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to