dstandish commented on issue #31720: URL: https://github.com/apache/airflow/issues/31720#issuecomment-1579179063
And to clarify your specific question re max attempts -- we don't want to do anything with max attempts here. The author of that PR was citing the logging deficiency as a reason why they wanted to monitor max attempts in the trigger -- because otherwise, they would get no messaging that the trigger was cancelled until the very end of the logs. We can remedy that here by adding a message about the cancellation at the time when the task is actually cancelled. Then there would be no need to worry about such messaging concerns in the trigger itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
