ephraimbuddy commented on code in PR #31018: URL: https://github.com/apache/airflow/pull/31018#discussion_r1221185282
########## airflow/providers/amazon/aws/hooks/s3.py: ########## @@ -38,6 +39,11 @@ from urllib.parse import urlsplit from uuid import uuid4 +try: + from aiobotocore.client import AioBaseClient +except ImportError: + pass Review Comment: This can be imported under type checking since it's only used for type checking. Also, why are we passing if there's an import error? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
