phanikumv commented on code in PR #31641:
URL: https://github.com/apache/airflow/pull/31641#discussion_r1221328343
##########
tests/providers/amazon/aws/operators/test_emr_create_job_flow.py:
##########
@@ -192,3 +195,24 @@ def test_execute_with_wait(self, mock_waiter, *_):
assert self.operator.execute(self.mock_context) == JOB_FLOW_ID
mock_waiter.assert_called_once_with(mock.ANY,
ClusterId=JOB_FLOW_ID, WaiterConfig=mock.ANY)
assert_expected_waiter_type(mock_waiter, "job_flow_waiting")
+
+ @patch.object(S3Hook, "parse_s3_url", return_value="valid_uri")
+ def test_create_job_flow_deferrable(self, _):
+ self.emr_client_mock.run_job_flow.return_value =
RUN_JOB_FLOW_SUCCESS_RETURN
Review Comment:
please add docstring describing what this test is supposed to do. This need
to be done for all the newly added tests
##########
docs/apache-airflow-providers-amazon/operators/emr/emr.rst:
##########
@@ -47,6 +47,7 @@ Create an EMR job flow
You can use
:class:`~airflow.providers.amazon.aws.operators.emr.EmrCreateJobFlowOperator` to
create a new EMR job flow. The cluster will be terminated automatically after
finishing the steps.
+This operator can be run in deferrable mode by passing ``deferrable=True`` as
a parameter.
Review Comment:
```suggestion
This operator can be run in deferrable mode by passing ``deferrable=True``
as a parameter.Using ``deferrable`` mode will release worker slots and leads to
efficient utilization of resources within Airflow cluster.However this mode
will need the Airflow triggerer to be available in your deployment.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
