potiuk commented on PR #31754:
URL: https://github.com/apache/airflow/pull/31754#issuecomment-1581175983
I think two is more consistent with the idea behind. We don't really replace
the character, we account for the fact that our config has no hierarchy of
configurations. So one could argue that `.` represents subsection, not `.` in
the section name. In ideal world we would have:
```
[providers]
[odbc]
config = value
```
And then `__` would make perfect sense. But we can't because we are using
the old ini format that does not have it.
But it has hit people back in the past even for regular sections. That's why
in
https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#elasticsearch-configs
the env variables is explicitly spelled exactly as they should be this is the
"discoverabilty" that we are missing currently that I mentioned in the slack
thread. And since then I can't recall single issue with using `__` as separator
between section and config.
I think if we care for users not making mistakes we should be very precise
and add examples in the docs that they will be able to copy&paste - both for
config and variable. And once we do it, decision whether to use `__` or `_`
makes little difference.
(BTW. That does recall some of the discussions we had years ago when we
wanted to add google provider specific config).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
