vandonr-amz commented on code in PR #31018:
URL: https://github.com/apache/airflow/pull/31018#discussion_r1221966761
##########
airflow/providers/amazon/aws/sensors/s3.py:
##########
@@ -93,6 +96,8 @@ def __init__(
self.check_fn = check_fn
self.aws_conn_id = aws_conn_id
self.verify = verify
+ self.deferrable = deferrable
+ self.should_check_fn = True if check_fn else False
Review Comment:
what I mean is that instead of computing it here and storing it in a class
field, you could just do that `True if check_fn else False` in the only place
where you use it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
