utkarsharma2 commented on code in PR #31662:
URL: https://github.com/apache/airflow/pull/31662#discussion_r1222475096


##########
airflow/www/views.py:
##########
@@ -3084,6 +3084,7 @@ class GraphForm(DateTimeWithNumRunsWithDagRunsForm):
             t.task_id: {
                 "dag_id": t.dag_id,
                 "task_type": t.task_type,

Review Comment:
   Yes, I think we still need this since the below code compares the operator 
class name
   
https://github.com/apache/airflow/blob/8891c6944671d8965a63ddbd59b5c23597e86f0a/airflow/www/static/js/graph.js#L211
   and based on that displaying the subdag button -
   
https://github.com/apache/airflow/blob/8891c6944671d8965a63ddbd59b5c23597e86f0a/airflow/www/static/js/callModal.js#L185-L190
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to