phanikumv commented on code in PR #31783:
URL: https://github.com/apache/airflow/pull/31783#discussion_r1223281533


##########
tests/providers/microsoft/azure/hooks/test_wasb.py:
##########
@@ -197,6 +214,12 @@ def test_connection_extra_arguments_public_read(self):
         conn = hook.get_conn()
         assert conn._config.proxy_policy.proxies == self.proxies
 
+    def test_extra_client_secret_auth_config_ad_connection(self):

Review Comment:
   Did you verify that connection is being done correctly after this change? 
Can you please include a screenshot in the description.
   
   May be you need to do that by running a ADF example DAG using an actual 
`azure` conn, and verify by running it using a service principal 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to