dstandish commented on code in PR #31808:
URL: https://github.com/apache/airflow/pull/31808#discussion_r1223598211
##########
airflow/triggers/base.py:
##########
@@ -119,3 +119,34 @@ def __eq__(self, other):
if isinstance(other, TriggerEvent):
return other.payload == self.payload
return False
+
+
+class BaseTaskEndEvent(TriggerEvent):
+ """Base event class to end the task without resuming on worker."""
+
+ task_instance_state: TaskInstanceState
+
+ def __init__(self, *, xcom_return: Any = None, other_xcom: dict[str, Any]
| None = None, **kwargs):
Review Comment:
this particular bit of the interface... open to suggestions on.... basically
anything in this file there's a lot of ways we could've gone... but in
particular the xcom_return vs other_xcom split and naming.
i thought having them explicit like this is better than having something
"implicitly" go to `return_value` etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
