potiuk opened a new pull request, #31813:
URL: https://github.com/apache/airflow/pull/31813

   Pre-commit prints a useful message when static check changes
   
   ```
   Update ER 
diagram..................................................................Passed
   pre-commit hook(s) made changes.
   If you are seeing this message in CI, reproduce locally with: `pre-commit 
run --all-files`.
   To run `pre-commit` as part of git workflow, use `pre-commit install`.
   All changes made by hooks:
   ```
   
   But it is not highglighted in any way in the CI output and it might be 
missed when users are not familiar with pre-commit.
   
   We  repeat the message and add more detailed instructions what to do 
(Including helpful `breeze static-checks --only-my-changes` commamnd that helps 
to run static checks faster. We do it also in the way that will be more 
prominently displayed at the end of the output and highlighted. We can point 
the user to follow those instructions if they ask rather than explain them to 
look at CONTRIBUTING guide.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to