dstandish commented on code in PR #31820:
URL: https://github.com/apache/airflow/pull/31820#discussion_r1224769330


##########
tests/core/test_configuration.py:
##########
@@ -1447,3 +1448,36 @@ def test_future_warning_only_for_code_ref(self, key):
             w = captured.pop()
             assert "your `conf.get*` call to use the new name" in 
str(w.message)
             assert w.category == FutureWarning
+
+
+def test_sensitive_values():
+    from airflow.settings import conf
+
+    # this list was hardcoded prior to 2.6.2
+    # included here to avoid regression in refactor
+    # inclusion of keys ending in "password" or "kwargs" is automated from 
2.6.2

Review Comment:
   basically ... erring on side of caution. mind you it's just the test to 
gather "suspected" sensitive. and we can ignore kwargs entries that are 
determined not sensitive.  essentially, forces an author to decide if item is 
sensitive when adding a kwargs config entry.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to