Lee-W commented on code in PR #31757:
URL: https://github.com/apache/airflow/pull/31757#discussion_r1225238078
##########
airflow/jobs/triggerer_job_runner.py:
##########
@@ -608,6 +608,8 @@ async def run_trigger(self, trigger_id, trigger):
self.log.info("Trigger %s fired: %s",
self.triggers[trigger_id]["name"], event)
self.triggers[trigger_id]["events"] += 1
self.events.append((trigger_id, event))
+ except asyncio.CancelledError:
+ self.log.info("Trigger cancelled")
Review Comment:
At first, I believed it to be the case. However, upon further consideration,
we may come across different scenarios as well. How about we log the exception
itself? like
```python
except asyncio.CancelledError as err:
self.log.info("Trigger cancelled due to {str(err)}")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
