[
https://issues.apache.org/jira/browse/AIRFLOW-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894587#comment-16894587
]
ASF GitHub Bot commented on AIRFLOW-4451:
-----------------------------------------
AetherUnbound commented on pull request #5673: [AIRFLOW-4451] Allow templated
named tuples
URL: https://github.com/apache/airflow/pull/5673
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-4451
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [X] Here are some details about my PR, including screenshots of any UI
changes:
PR #4691 introduced an issue where named tuples were inadvertently converted
to a list of rendered entities. This then made subsequent attribute access on
what was assumed to be a named tuple fail, since the object was actually a list.
Example:
```python
from collections import namedtuple
Test = namedtuple('Test', ['foo', 'bar'])
t = Test(1, 2)
t = render_template(t) # `t` is now a list of [1, 2]
print(t.foo) # This fails after rendering
```
This PR adds an additional clause in the base render function to catch named
tuples, and re-instantiate them as the proper class after variable rendering.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
This adds another clause to the python operator tests to ensure that
rendered `op_args` that are named tuples are still preserved.
### Commits
- [X] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [ ] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [AIRFLOW-1814] converts namedtuples args in PythonOperators to lists
> --------------------------------------------------------------------
>
> Key: AIRFLOW-4451
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4451
> Project: Apache Airflow
> Issue Type: Bug
> Components: operators
> Affects Versions: 1.10.3
> Reporter: Ross Mechanic
> Assignee: Matthew Bowden
> Priority: Major
>
> Upgrading to Airflow 1.10.3 from Airflow 1.10.2 removed support for passing
> in `namedtuple`s as `op_kwargs` or `op_args` to `PythonOperator`. The
> specific PR that made the breaking change is
> [https://github.com/apache/airflow/pull/4691]
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
