vandonr-amz commented on code in PR #31824:
URL: https://github.com/apache/airflow/pull/31824#discussion_r1225619320
##########
airflow/providers/amazon/aws/hooks/logs.py:
##########
@@ -63,7 +63,7 @@ def get_log_events(
start_time: int = 0,
skip: int = 0,
start_from_head: bool = True,
- continuation_token: ContinuationToken = ContinuationToken(),
+ continuation_token: ContinuationToken | None = None,
Review Comment:
with the previous version, I didn't realize that the "default object" is
created only once. And since we modify it in the method, the default object is
modified, and when this method is called again with the default parameters,
instead of getting a clean object, we get the modified one from the last call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
