potiuk commented on issue #31818: URL: https://github.com/apache/airflow/issues/31818#issuecomment-1586108639
> I don't see any existing unit tests for either the db_commands.check function or the db.check function in the test suite. I assume that since this code change is introducing non-trivial logic into the procedure of airflow db check, some unit tests would be needed? I am not sure about how to approach this though. Just look at `tests/cli/commands/test_db_command.py` -> it has some ways other db commands have been tested, This should be similar. Mocking what's necessary (for example mocking out the call to the DB and pretending it failed) and testing just the retry logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
