uranusjr commented on code in PR #31846:
URL: https://github.com/apache/airflow/pull/31846#discussion_r1226105667


##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -264,15 +266,39 @@ def last_description(self) -> Sequence[Sequence] | None:
             return None
         return self.descriptions[-1]
 
+    @overload
+    def run(
+        self,
+        sql: str | Iterable[str],
+        autocommit: bool = ...,

Review Comment:
   Let’s copy the real defaults since they are quite simple. This would be much 
friendlier to editor popups.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to