jens-scheffler-bosch commented on code in PR #31301:
URL: https://github.com/apache/airflow/pull/31301#discussion_r1227312775
##########
airflow/example_dags/example_params_ui_tutorial.py:
##########
@@ -159,9 +156,10 @@
),
# Fields can be required or not. If the defined fields are typed they
are getting required by default
# (else they would not pass JSON schema validation) - to make typed
fields optional you must
- # permit the optional "null" type
+ # permit the optional "null" type.
+ # You can omit a default value if the DAG is triggered manually
"required_field": Param(
- "You can not trigger if no text is given here!",
+ # Do not provide a default value but form will enforce a value
supplied by users
Review Comment:
Thanks. Good point. Adjusted the comment ... and as I had my hand's dirty on
this added some more tests for valid and invalid params parsing as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
