uranusjr commented on code in PR #31862:
URL: https://github.com/apache/airflow/pull/31862#discussion_r1228526872
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -873,6 +874,11 @@ def dry_run(self) -> None:
pod = self.build_pod_request_obj()
print(yaml.dump(prune_dict(pod.to_dict(), mode="strict")))
+ def progress_callback(self) -> None:
+ """
+ Expose a callback hook on status lines
+ """
+ pass
Review Comment:
Instead of providing an empty function that needs to be overridden by
subclassing, I wonder if this should instead be an argument to the operator. So
users can do something like
```python
def progress_callback(message):
....
t1 = KubernetesPodOperator(
...,
progress_callback=progress_callback,
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
