syedahsn commented on code in PR #31657: URL: https://github.com/apache/airflow/pull/31657#discussion_r1228731137
########## tests/providers/amazon/aws/triggers/test_eks.py: ########## @@ -0,0 +1,312 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from unittest import mock +from unittest.mock import AsyncMock + +import pytest +from botocore.exceptions import WaiterError + +from airflow.providers.amazon.aws.hooks.eks import EksHook +from airflow.providers.amazon.aws.triggers.eks import ( + EksCreateFargateProfileTrigger, + EksDeleteFargateProfileTrigger, +) +from airflow.triggers.base import TriggerEvent + +TEST_CLUSTER_IDENTIFIER = "test-cluster" +TEST_FARGATE_PROFILE_NAME = "test-fargate-profile" +TEST_POLL_INTERVAL = 10 +TEST_MAX_ATTEMPTS = 10 +TEST_AWS_CONN_ID = "test-aws-id" + + +class TestEksCreateFargateProfileTrigger: + def test_eks_create_fargate_profile_serialize(self): + eks_create_fargate_profile_trigger = EksCreateFargateProfileTrigger( + cluster_name=TEST_CLUSTER_IDENTIFIER, + fargate_profile_name=TEST_FARGATE_PROFILE_NAME, + aws_conn_id=TEST_AWS_CONN_ID, + poll_interval=TEST_POLL_INTERVAL, + max_attempts=TEST_MAX_ATTEMPTS, + ) + + class_path, args = eks_create_fargate_profile_trigger.serialize() + assert class_path == "airflow.providers.amazon.aws.triggers.eks.EksCreateFargateProfileTrigger" + assert args["cluster_name"] == TEST_CLUSTER_IDENTIFIER + assert args["fargate_profile_name"] == TEST_FARGATE_PROFILE_NAME + assert args["aws_conn_id"] == TEST_AWS_CONN_ID + assert args["poll_interval"] == str(TEST_POLL_INTERVAL) + assert args["max_attempts"] == str(TEST_MAX_ATTEMPTS) + + @pytest.mark.asyncio + @mock.patch.object(EksHook, "async_conn") + async def test_eks_create_fargate_profile_trigger_run(self, mock_async_conn): + a_mock = mock.MagicMock() + mock_async_conn.__aenter__.return_value = a_mock + + a_mock.get_waiter().wait = AsyncMock() + + eks_create_fargate_profile_trigger = EksCreateFargateProfileTrigger( + cluster_name=TEST_CLUSTER_IDENTIFIER, + fargate_profile_name=TEST_FARGATE_PROFILE_NAME, + aws_conn_id=TEST_AWS_CONN_ID, + poll_interval=TEST_POLL_INTERVAL, + max_attempts=TEST_MAX_ATTEMPTS, + ) + + generator = eks_create_fargate_profile_trigger.run() + response = await generator.asend(None) + + assert response == TriggerEvent({"status": "success", "message": "Fargate Profile Created"}) + + @pytest.mark.asyncio + @mock.patch("asyncio.sleep") + @mock.patch.object(EksHook, "async_conn") + async def test_eks_create_fargate_profile_trigger_run_multiple_attempts( + self, mock_async_conn, mock_sleep + ): + a_mock = mock.MagicMock() Review Comment: Thats a good point. My only concern is that often there are minor changes between each setup. I'll see if there's a way to package it all in a setup method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
