vandonr-amz commented on code in PR #31881:
URL: https://github.com/apache/airflow/pull/31881#discussion_r1228638295
##########
airflow/providers/amazon/aws/operators/ecs.py:
##########
@@ -490,7 +549,26 @@ def execute(self, context, session=None):
if self.reattach:
self._try_reattach_task(context)
- self._start_wait_check_task(context)
+ self._start_wait_task(context)
+
+ self._after_execution(session)
+
+ if self.do_xcom_push and self.task_log_fetcher:
+ return self.task_log_fetcher.get_last_log_message()
+ else:
+ return None
+
+ def execute_complete(self, context, event=None):
+ if event["status"] != "success":
+ raise AirflowException(f"Error in task execution: {event}")
+ self.arn = event["task_arn"] # restore arn to its updated value
+ self._after_execution()
+ if self._aws_logs_enabled():
+ ... # TODO return last log line but task_log_fetcher will always
be None here
Review Comment:
this is why this PR is in DRAFT status
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
