utkarsharma2 commented on code in PR #31836:
URL: https://github.com/apache/airflow/pull/31836#discussion_r1228841822
##########
airflow/cli/commands/db_command.py:
##########
@@ -187,9 +188,18 @@ def shell(args):
@cli_utils.action_cli(check_db=False)
-def check(_):
+def check(args):
"""Runs a check command that checks if db is available."""
- db.check()
+ retries: int = args.retry
+ retry_delay: int = args.retry_delay
+
+ for attempt in Retrying(
Review Comment:
Yup, there is no need to test for tenacity code.
Also, reraising the original exception is vital as it gives users a hint of
what needs to be done next, whereas RetryError would be meaningless to them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
