Aakcht commented on PR #31865: URL: https://github.com/apache/airflow/pull/31865#issuecomment-1590482722
@jedcunningham actually statsd is only half excluded from using globals - since `Values.securityContexts.containers` is getting propagated without issues to statsd container (note how [containerSecurityContext](https://github.com/apache/airflow/blob/main/chart/templates/statsd/statsd-deployment.yaml#L30) is used in statsd deployment instead of [localContainerSecurityContext](https://github.com/apache/airflow/blob/main/chart/templates/_helpers.yaml#L789)). So it looks a bit inconsistent to me. As for redis, I don't use it, so I didn't notice the problem :( Looks like it's the same issue with the redis: according to documentation, global security context should be used when local is not specified, see https://github.com/apache/airflow/blob/main/chart/values.schema.json#L5520 . I added the same change for redis. However if you think it'll be better to use only local security context for statsd/redis, I can modify the PR - to change the documentation and add local redis/statsd container security context logic. In this case I suspect [localContainerSecurityContext](https://github.com/apache/airflow/blob/main/chart/templates/_helpers.yaml#L789) should be used for redis/statsd container security context . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
