ephraimbuddy commented on code in PR #31887:
URL: https://github.com/apache/airflow/pull/31887#discussion_r1229126814
##########
airflow/dag_processing/processor.py:
##########
@@ -530,7 +530,13 @@ def manage_slas(cls, dag_folder, dag_id: str, session:
Session = NEW_SESSION) ->
for callback in callbacks:
cls.logger().info("Calling SLA miss callback %s", callback)
try:
- callback(dag, task_list, blocking_task_list, slas,
blocking_tis)
+ callback(
+ dag=dag,
+ task_list=task_list,
+ blocking_task_list=blocking_task_list,
+ slas=slas,
+ blocking_tis=blocking_tis,
+ )
Review Comment:
Can we also confirm that callbacks work, not just notifiers, because this
looks like a breaking change?
You can use this callback for sla:
```python
def my_sla_callback(dag, task_list, blocking_task_list, slas, blocking_tis):
print(blocking_task_list)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
