uranusjr commented on code in PR #31808:
URL: https://github.com/apache/airflow/pull/31808#discussion_r1229223992
##########
airflow/triggers/base.py:
##########
@@ -119,3 +119,34 @@ def __eq__(self, other):
if isinstance(other, TriggerEvent):
return other.payload == self.payload
return False
+
+
+class BaseTaskEndEvent(TriggerEvent):
+ """Base event class to end the task without resuming on worker."""
+
+ task_instance_state: TaskInstanceState
+
+ def __init__(self, *, xcom_return: Any | None = None, other_xcom:
dict[str, Any] | None = None, **kwargs):
+ if "payload" in kwargs:
+ raise ValueError("Param 'payload' not supported for this class.")
Review Comment:
I don’t think so? The suggested change removed `payload` altogether and
should raise TypeError when it is provided. Or is the issue you want to allow
`**kwargs`? But I don’t see any subclass using that either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
