eladkal commented on code in PR #31884:
URL: https://github.com/apache/airflow/pull/31884#discussion_r1230215453
##########
airflow/providers/amazon/aws/operators/ecs.py:
##########
@@ -202,53 +202,39 @@ class
EcsDeregisterTaskDefinitionOperator(EcsBaseOperator):
:param task_definition: The family and revision (family:revision) or full
Amazon Resource Name (ARN)
of the task definition to deregister. If you use a family name, you
must specify a revision.
- :param wait_for_completion: If True, waits for creation of the cluster to
complete. (default: True)
- :param waiter_delay: The amount of time in seconds to wait between
attempts,
- if not set then the default waiter value will be used.
- :param waiter_max_attempts: The maximum number of attempts to be made,
- if not set then the default waiter value will be used.
"""
- template_fields: Sequence[str] = ("task_definition", "wait_for_completion")
+ template_fields: Sequence[str] = "task_definition"
Review Comment:
This is a breaking change
Even if it doesn't mean anything if user has templating over this field and
we remove it his code will break.
We should keep it until we remove the parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
