potiuk commented on PR #31920: URL: https://github.com/apache/airflow/pull/31920#issuecomment-1592725217
Looks fantastic. Will open up for Elasticsearch 8 migration. What we will also need is a note in the elasticsearch Changelog.rst and bumping the version there (and in provider.yaml) to 5.* - this is not a breaking change per-se, but it removes the dsl dependencies, that some users might rely on, so IMHO at the very least we need to raise MAJOR version of the elasticsearch provider and make people aware that if they want to to continue using the libraries they have to install them on their own. I think this also means (see the change in the dockerfile test) that we need to make a similar note in the `docs/docker-stack/changelog.rst`. We are unlikely to cherry-pick that one to 2.6 (that would be too disruptive of a change to get rid of the dependencies in 2.6.3 in the image I think, so we can make it as an upcoming 2.7 change in the image. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
