mikelius2b opened a new issue, #31930:
URL: https://github.com/apache/airflow/issues/31930

   ### Apache Airflow version
   
   2.6.1
   
   ### What happened
   
   There are two problems with new form which forms DAG config.
   
   ### 1. It doesn't allow to fill valid float with two or two decimal places
   This param in DAG code looks like: `Param(default=None, type=["number", 
"null"]`
   But in form we get:
   ![Screenshot 2023-06-15 at 13 23 
28](https://github.com/apache/airflow/assets/127402220/236b8793-4657-4026-9023-e6cbe2dea3b8)
   
   ### 2. It doesn't considers empty string as filled parameter
   
   - in DAG we have param `'param1': Param(default='', type='string')`
   - expectation is that we don't need to fill such param in form
   - but form asks us to fill it
   ![Screenshot 2023-06-15 at 13 32 
48](https://github.com/apache/airflow/assets/127402220/efbe22aa-3aad-414e-88c3-6779eb04eca3)
   
   ### 3. There is some strange behavior in interaction between filled form and 
"Generated Configuration JSON"
   
   - we fill form
   - we paste manually created JSON into configuration field
   - DAG runs with configuration from JSON
   
   This helped us to overcome problem from p.1 and p.2, but it seems not very 
reliable, probably parameters in form should be synced with JSON.
   
   ### What you think should happen instead
   
   Problem 1: field allows to fill proper float values.
   Problem 2: field don't need to be filled
   Problem 3: values in JSON synced with values in form
   
   ### How to reproduce
   
   Problem 1:
   1. Create DAG with number param
   2. Try to fill `0.01` into this param field in Trigger DAG with config form
   
   Problem 2:
   1. Create DAG with param `Param(default='', type="string"`
   2. Try run DAG with config without filling corresponding field
   
   Problem 3:
   1. Create DAG with some params
   2. Go to Trigger DAG page and fill parameters in form
   3. Insert custom JSON in "Generated Configuration JSON"
   4. Run DAG
   
   ### Operating System
   
   MacOS
   
   ### Versions of Apache Airflow Providers
   
   _No response_
   
   ### Deployment
   
   Official Apache Airflow Helm Chart
   
   ### Deployment details
   
   _No response_
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to