o-nikolas commented on code in PR #31786:
URL: https://github.com/apache/airflow/pull/31786#discussion_r1231272315
##########
airflow/providers/amazon/aws/hooks/ecs.py:
##########
@@ -198,7 +196,18 @@ def _event_to_str(self, event: dict) -> str:
return f"[{formatted_event_dt}] {message}"
def get_last_log_messages(self, number_messages) -> list:
- return [log["message"] for log in deque(self._get_log_events(),
maxlen=number_messages)]
+ """
+ Gets the last logs messages in one single request, so restrictions
apply:
+ - if logs are too old, the response will be empty
Review Comment:
I'm not sure I grok this. Why should reading from the bottom of a log stream
be any different depending on how old the stream is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
