jedcunningham commented on code in PR #31712:
URL: https://github.com/apache/airflow/pull/31712#discussion_r1231204411
##########
airflow/providers/google/cloud/transfers/gcs_to_bigquery.py:
##########
@@ -42,6 +42,13 @@
from airflow.providers.google.cloud.links.bigquery import BigQueryTableLink
from airflow.providers.google.cloud.triggers.bigquery import
BigQueryInsertJobTrigger
+# TODO: once we update the minimum Airflow version to 2.7.0
+# remove this try-exception block and
+# inherit BaseDeferrableOperator for operator with deferrable attribute
+try:
+ from airflow.models.baseoperator import DEFAULT_DEFERRABLE
+except ImportError:
+ DEFAULT_DEFERRABLE = False
Review Comment:
```suggestion
DEFAULT_DEFERRABLE = False
```
tiny nit
##########
airflow/providers/amazon/aws/operators/sagemaker.py:
##########
@@ -34,6 +34,13 @@
from airflow.providers.amazon.aws.utils.tags import format_tags
from airflow.utils.json import AirflowJsonEncoder
+# TODO: once we update the minimum Airflow version to 2.7.0
+# remove this try-exception block and
+# inherit BaseDeferrableOperator for operator with deferrable attribute
+try:
+ from airflow.models.baseoperator import DEFAULT_DEFERRABLE
+except ImportError:
+ DEFAULT_DEFERRABLE = False
Review Comment:
```suggestion
DEFAULT_DEFERRABLE = False
```
tiny nit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
