dstandish commented on code in PR #31757:
URL: https://github.com/apache/airflow/pull/31757#discussion_r1231892590
##########
airflow/jobs/triggerer_job_runner.py:
##########
@@ -608,6 +609,17 @@ async def run_trigger(self, trigger_id, trigger):
self.log.info("Trigger %s fired: %s",
self.triggers[trigger_id]["name"], event)
self.triggers[trigger_id]["events"] += 1
self.events.append((trigger_id, event))
+ except asyncio.CancelledError as err:
+ trigger_timeout = trigger.task_instance.trigger_timeout
+ if trigger_timeout:
+ if not trigger_timeout.tzinfo:
+ trigger_timeout =
trigger_timeout.replace(tzinfo=timezone.utc)
+
+ if trigger_timeout < timezone.utcnow():
+ self.log.error("Trigger cancelled due to timeout")
+
+ self.log.error("Trigger cancelled; message=%s", err)
+ raise
Review Comment:
this suggestion is a bit golfy, but hey
```suggestion
except asyncio.CancelledError as err:
if timeout := trigger.task_instance.trigger_timeout:
timeout = timeout.replace(tzinfo=timezone.utc) if not
timeout.tzinfo else timeout
if timeout < timezone.utcnow():
self.log.error("Trigger cancelled due to timeout")
self.log.error("Trigger cancelled; message=%s", err)
raise
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
