ephraimbuddy commented on code in PR #31953:
URL: https://github.com/apache/airflow/pull/31953#discussion_r1231894101
##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -90,8 +90,17 @@ def get_link(
*,
ti_key: TaskInstanceKey,
):
- job_id = XCom.get_value(key="job_id", ti_key=ti_key)
- return BIGQUERY_JOB_DETAILS_LINK_FMT.format(job_id=job_id) if job_id
else ""
+ job_id_params = XCom.get_value(key="job_id_params", ti_key=ti_key)
Review Comment:
We should probably do the renaming when we want to release a major version
because it's a breaking change for anyone using the `job_id` already. Add #TODO
and explain to bump this in a major release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
